I never made assumptions about your mental health. As I said way up there ^... you needed to brace yourself for what we were about to say. This is all constructive feedback you're getting here, because we thought (hoped?) you are open to it for the betterment of your code.
If alarlib was both standalone (not embed) and a transition to using Ace2, while I didn't know, but I understand. Just understand that I've opened many an addon where the Ace2 libs are used so poorly, it actually makes things worse. Or they're embedded and never used... or embedded just to use one simple tiny function out of the whole big thing... or... you get my point.
Yes, we are criticizing your code. We're not doing it to spite you, we want to help make it better. If you don't want us to, just say so and we'll stop.
Well, it's more like "infamous" than "legendary"... #wowace isn't that bad, if you ignore all the whiney bitchy users. I'm happy to hear you don't use the lib in your new stuff, and well, we don't really exactly "check" your code there... it's more of a thing to point at and say "don't do that!"
The main reason it was brought up is because you load all that code in every addon that uses it, which is usually a bad thing. A good chunk of it is redundant, especially if you're using the ace libs. It's kinda assumed (though not required) that if you're submitting to ace's svn you're using the ace libs. Besides that, submitting into the svn is usually a sign that you're part of this community and want feedback from the other devs here. We all help each other out with improvements, or even just a smack upside the head to tell you "don't do that!"
And I think it's safe to say that noone else uses your lib *grin*.
You should still hop on #wowace. A good portion of the devs there are not english-native, and they're all there to help each other out, and get help in return.
Hey now be nice! What what the fuck am I saying I'm never nice.
Seriously tho, alar, you should hop on IRC and listen to people's advice... just be prepared for a lot of it, those of us that have looked at your library... well... Let me put it this way, your library is like the borg, it assimilates every idea it comes across that appears to maybe be useful at some point in time to someone, somewhere.
People are willing to help, just be prepared for it, because it's not going to be pretty. And don't take it personally, bad shit always happens when people take things personally...
I can see why it was removed, it's basically pure fluff...
-- Do the crap you want when leaving combat
All you have to do is register for PLAYER_REGEN_ENABLED where you would have called ScheduleLeaveCombatAction. You still have to create a function for it to call in either design, so why is ScheduleLeaveCombatAction needed at all?