I've run the dataminer on most of the tradeskill sets myself now, resulting in tons of changes.
Maybe you are using the cache functionality of the dataminer and it somehow gave you old data for some sets?
So r289 should now have really fixed it.
Hmm, I think I only run it on Tradeskill.Crafted.BlackSmithing to check my fix and forgot to run it on the other ones.
As a side note, the cache is used only on the raw HTML pages returned by wowhead. The sqlite based cache use a default timeout of 7 days.
I plan on committing a little lib that I have written to read JSON data and rewrite the miner to use that later today or tomorrow.
Edit: There are quite a bit of other changes in wowhead's format (even URL format). The update is bigger than expected, lots of small functions were added to the miner, some of them not using the internal API. I'm rewriting a lot of it.
The list of items that goes in the keyring appears to be very truncated (i.e. 20 keys in the list, WoWHead returns 153 keys in the game). Examining data.lua shows that it's not autogenerated. Is there a reason behind this?
Most probably nobody added the correct query to the dataminer.
Last thing I did was checking what wowhead actually had to say about Transmute: Earthstorm Diamond. It is located in the Database -> Spells -> Uncategorized section whereas the rest are located in the Database -> Spells -> Professions -> Alchemy.
Looking at the other items in the uncategorized section makes me believe that Earthstorm (and the rest) are simply not classified correctly with wowhead.
So ask wowhead to fix their DB, and it's gonna fix your issue.
I vote separate file and call it Currency or CurrencyItems or something. However I do not have a mod that uses any of that. Is there a mod that specifically uses Gear.Vendor to match up vendors with gear?
and wrt the herb, are thy in all tables? iirc the MatsByType tables aren't mined by the dataminer but done by hand.
Indeed. "Tradeskill.Mat.ByType.*" are not generated. Some of them are really tricky to try to automatically generate, although it looks like it shouldn't be impossible. I have absolutely no time to work on it, though.
I ran the full miner and checked that in. It only affected ClassSpell.
All Northrend herbs are in the last version(s) of PT. Something else is the cause of the issue.
Adding the sort is a good idea. I thought about adding it myself when I rewrote the core of the dataminer, but never did. Note that running the dataminer with a debug level above 2 should print a 'diff' of each sets that changed.