Also having the problem of not resetting aggro between phases.
Took a quick peek at the Souls.lua file, there's a typo on line 37, it says Souls:RegisterTranslations when it should say Souls:RegisterTranslation :)
I don't know if that would fix it, since I haven't had the chance to try it yet, but I'm gonna do some more testing on our next BT raid on sunday. Hopefully we'll get some answers then :)
This module did not work when I posted it, I'm sorry. I didn't intend for it to get stuck directly into Threat without some additional testing. I'm not sure who put it in. Not that I mind it was included, just that it definitely needs more work.
Example, I'm pretty sure line 17 needs to read
ThreatLib:GetModule("NPCCore"):RegisterModule(BB["Essence of Anger"], BB["Essence of Desire"], BB["Essence of Suffering"], function(Souls)
Right now it just has BB["Essence of Anger"]
I'll run a test of this on my local copy on Tuesday after the reset, soon as we get back to RoS
After some stupid text editor related mistakes, here is the file in UTF-8. If anyone would like to review it, that would be great. Anger engage translations are needed for all locales. The other translations are from the BigWigs module.
Talked with Funky a bit on IRC and he was saying that he never runs into the situation I described above. Although, I am forced to manually reset Omen via Shift+Click each week to clear global threat. I was wondering if anyone else is running into issues going from Desire to Anger? Is your global threat being reset?
Either way, it was fun to make the module, even if it ends up not being needed.
edit: I think I made a typo in the Souls.lua file. Going to re-attach one that should be cleaned up.
Antiarc, the links on the first post of this thread to Trac are coming up with errors. Guessing because they switched to Jira? Hope it's ok to report things here still. Two things.
1) There's a very minor typo in the Bloodboil.lua file, it references Void Reaver instead of Bloodboil:
ThreatLib:Debug("Not registering Eject for Void Reaver: translation does not exist for %s", GetLocale())
2) I mentioned this previously, but Reliquary of Souls in Black Temple could use a module to reset global threat after each Essence is defeated. Currently, when you finish coming down the ramp to engage Essence of Suffering, you usually drop out of combat for a few seconds which is enough to reset threat. When Essence of Suffering is defeated, you usually again drop out of combat for a second or two before the Enslaved Souls spawn. This again is usually enough to reset threat. The problem is that after Essence of Desire is defeated, you either never or extremely rarely drop out of combat and global threat is not reset. So when Essence of Anger is engaged, the threat meter is all over the place.
Essence of Suffering yells: Pain and suffering are all that await you!
Essence of Desire yells: You can have anything you desire... for a price.
Essence of Anger yells: Beware. I live!
I'm trying to adapt the Zul'jin module to Souls. Zul'jin was the first encounter I could think of with multiple phases like Souls, each accompanied by a yell. I need to test it, though.
At Leotheras we have a warlock tank the demon phase. He opens up with a timed curse of doom. For the first moments he's not showing up on the threat meter. He catches up with most of us, but some people still appear ahead of him. He maintains aggro, so it hasn't been much of an issue in our raids. However, it seems to me that curse of doom's threat might not be counted for. That's the only thing I can figure.
We use a Warlock in FR gear with a CoD as well. I have not seen this happen.
Is it possible his CoD is going off before the Demon phase?
Certainly, we can add a boss module for it. Can someone corroborate that observation?
He's correct. Temporus in The Black Morass instance of Caverns of Time has a knockback with either an exceedingly small or zero aggro reduction. On more than one occasion I've done this instance and I will be sitting directly under the tank in threat and after the knockback, he sticks on the tank.
When going from Al'ar phase 1 to Al'ar phase 2, the threat display only shows global threat. Because Al'ar maintains his threat list between phase 1 and 2, it would be very helpful if the threat display could continue to show threat for Al'ar during the ten second period between phase 1 and 2.
Might not be possible because Al'ar is untargetable during this ten second period.
1. In heroic mode Caverns of Time: Black Morass, the second boss mob - Temporus - has a Wing Buffet style knock back move. This move is not a 50% aggro reduction. It is either a very small or zero aggro reduction. I believe he also has the Wing Buffet in regular mode and it also operates the same way.
2. In Serpentshrine Cavern, the Leotheras the Blind module is missing or failing to trigger an aggro wipe on one of the transitions. I apologize for this poor description and will attempt to provide better information regarding which wipe is missing next instance reset.